Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Query.blank, make it behave in withQueryParams #3520

Merged
merged 1 commit into from Jun 24, 2020

Conversation

rossabaker
Copy link
Member

@rossabaker rossabaker commented Jun 22, 2020

If a Uri has a trailing ?, calling withQueryParams on it should not preserve the empty parameter. We unfortunately already defined Query.empty to be the absence of a query string, so we need a new name. We probably should have made that an Option, which is something we can consider in 1.0.

I believe this will fix #3519.

hamnis
hamnis approved these changes Jun 24, 2020
@rossabaker rossabaker merged commit 8e46ed4 into http4s:series/0.21 Jun 24, 2020
10 checks passed
@rossabaker rossabaker deleted the blank-query branch Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants