Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise throwables into body if streaming has begun #3521

Merged
merged 1 commit into from Jun 24, 2020

Conversation

rossabaker
Copy link
Member

@rossabaker rossabaker commented Jun 23, 2020

async-http-client can call onThrowable after we've returned a response from onStream. We need a way to surface those to the client. We can't fail the response effect after we've already returned a response with a streaming body, but we can raise an error into that streaming body.

I haven't figured out a performant unit test, but my adaptation of @denisovlev's report is here.

Fixes #3509.

@rossabaker rossabaker added the bug Determined to be a bug in http4s label Jun 23, 2020
@rossabaker rossabaker added this to the 0.21.5 milestone Jun 23, 2020
hamnis
hamnis approved these changes Jun 24, 2020
@rossabaker rossabaker merged commit 4453153 into http4s:series/0.21 Jun 24, 2020
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Determined to be a bug in http4s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants