Fixes #3034 Allow configuring circe support parser #3583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwinbhaskar
changed the title
ashwinbhaskar
changed the title
rossabaker
reviewed
Jul 24, 2020
| @@ -97,7 +101,7 @@ trait CirceInstances extends JawnInstances { | |||
| implicit def jsonEncoder[F[_]]: EntityEncoder[F, Json] = | |||
| jsonEncoderWithPrinter(defaultPrinter) | |||
|
|
|||
| private def fromJsonToChunk(printer: Printer)(json: Json): Chunk[Byte] = | |||
| def fromJsonToChunk(printer: Printer)(json: Json): Chunk[Byte] = | |||
There was a problem hiding this comment.
What necessitated adding this to the public API?
There was a problem hiding this comment.
@rossabaker sorry, it slipped through. Not intentional. Added back the private and pushed.
There was a problem hiding this comment.
One more thing that slipped through was the first commit message containing a WIP in it. I modified the commit message to remove the WIP and force pushed.
ChristopherDavenport
approved these changes
Jul 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.