Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3034 Allow configuring circe support parser #3583

Merged
merged 4 commits into from Aug 6, 2020
Merged

Fixes #3034 Allow configuring circe support parser #3583

merged 4 commits into from Aug 6, 2020

Conversation

ashwinbhaskar
Copy link
Collaborator

@ashwinbhaskar ashwinbhaskar commented Jul 14, 2020

No description provided.

@ashwinbhaskar ashwinbhaskar changed the title [WIP] Fixes #3034 Allow configuring duplicate keys Fixes #3034 Allow configuring duplicate keys Jul 18, 2020
@ashwinbhaskar ashwinbhaskar changed the title Fixes #3034 Allow configuring duplicate keys Fixes #3034 Allow configuring circe support parser Jul 18, 2020
Copy link
Member

@rossabaker rossabaker left a comment

Looks good to me, but one quick question.

@@ -97,7 +101,7 @@ trait CirceInstances extends JawnInstances {
implicit def jsonEncoder[F[_]]: EntityEncoder[F, Json] =
jsonEncoderWithPrinter(defaultPrinter)

private def fromJsonToChunk(printer: Printer)(json: Json): Chunk[Byte] =
def fromJsonToChunk(printer: Printer)(json: Json): Chunk[Byte] =
Copy link
Member

@rossabaker rossabaker Jul 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What necessitated adding this to the public API?

Copy link
Collaborator Author

@ashwinbhaskar ashwinbhaskar Jul 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rossabaker sorry, it slipped through. Not intentional. Added back the private and pushed.

Copy link
Collaborator Author

@ashwinbhaskar ashwinbhaskar Jul 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing that slipped through was the first commit message containing a WIP in it. I modified the commit message to remove the WIP and force pushed.

@rossabaker rossabaker added the breaking Change breaks compatibility (binary or source) label Jul 24, 2020
Copy link
Member

@rossabaker rossabaker left a comment

Thanks!

@rossabaker rossabaker merged commit ba182c3 into http4s:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Change breaks compatibility (binary or source)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants