Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model Access-Control-Allow-Headers header #3587

Merged
merged 1 commit into from Aug 6, 2020
Merged

Model Access-Control-Allow-Headers header #3587

merged 1 commit into from Aug 6, 2020

Conversation

nelusnegur
Copy link
Contributor

This PR models Access-Control-Allow-Headers header as part of #2011. The header specification can be found on Fetch spec and MDN.
The header has the following syntax:

Access-Control-Allow-Headers: <header-name>[, <header-name>]*
Access-Control-Allow-Headers: *

rossabaker
rossabaker approved these changes Aug 6, 2020
View changes
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rossabaker rossabaker merged commit bed89dd into http4s:master Aug 6, 2020
@nelusnegur nelusnegur deleted the headers/access-control-allow-headers-model branch August 9, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossabaker rossabaker rossabaker approved these changes

@ChristopherDavenport ChristopherDavenport ChristopherDavenport approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nelusnegur @rossabaker @ChristopherDavenport