Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dsl.md #3595

Merged
merged 2 commits into from Aug 7, 2020
Merged

Update dsl.md #3595

merged 2 commits into from Aug 7, 2020

Conversation

sebastianvoss
Copy link

@sebastianvoss sebastianvoss commented Jul 20, 2020

As Year.of can throw an java.time.DateTimeException it results in an 500 errors if an invalid value is provided. Wrapping it in Either should prevent this.

As `Year.of` can throw an `java.time.DateTimeException` it results in an `500` errors if an invalid value is provided. Wrapping it in `Either` should prevent this.
@sebastianvoss
Copy link
Author

sebastianvoss commented Jul 20, 2020

If I'm not mistaken, Doc Site failed because leftMap did not exist in Scala 2.12. Let me know if I should back port this.

@rossabaker
Copy link
Member

rossabaker commented Aug 6, 2020

Thanks, and apologies for the slow reply.

Is importing cats.implicits._ enough to get the leftMap? I think it comes from bifunctor syntax.

Import `cats.implicits._` to get `leftMap`
@sebastianvoss
Copy link
Author

sebastianvoss commented Aug 6, 2020

@rossabaker You are right, the import is enough. I added it.

@rossabaker rossabaker added the docs Relates to our website or tutorials label Aug 7, 2020
@rossabaker rossabaker merged commit 4da88f5 into http4s:series/0.21 Aug 7, 2020
@rossabaker
Copy link
Member

rossabaker commented Aug 7, 2020

Test failure was unrelated. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Relates to our website or tutorials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants