Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use defaultHttpClient in JettyClient builder #3624

Merged
merged 1 commit into from Aug 7, 2020
Merged

Use defaultHttpClient in JettyClient builder #3624

merged 1 commit into from Aug 7, 2020

Conversation

taig
Copy link
Contributor

@taig taig commented Aug 5, 2020

I believe this might have been an oversight, comparing with alternativ clients such as AsyncHttpClient. Please feel free to close this PR if the current implementation was chosen for compatibility reasons.

@hamnis
Copy link
Contributor

hamnis commented Aug 5, 2020

Thanks for the PR @taig

Good spotted, please rebase this to series/0.21 so we can get a patch out faster.

@rossabaker rossabaker added bug Determined to be a bug in http4s retarget Cherry-pick or reopen on another branch labels Aug 5, 2020
@rossabaker rossabaker added this to the 0.21.7 milestone Aug 5, 2020
@taig taig changed the base branch from master to series/0.21 Aug 5, 2020
@rossabaker rossabaker merged commit d21dd7d into http4s:series/0.21 Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Determined to be a bug in http4s retarget Cherry-pick or reopen on another branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants