Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make requests to mock client cancelable #3659

Closed
wants to merge 2 commits into from

Conversation

bplommer
Copy link
Member

@bplommer bplommer commented Aug 25, 2020

Changes Client.fromHttpApp to run the app in Resource.liftF rather than Resource.make, to preserve cancelability.

@bplommer
Copy link
Member Author

bplommer commented Aug 28, 2020

As far as I can tell, the CI failure isn't related to the content of this PR.

hamnis
hamnis approved these changes Sep 21, 2020
Copy link
Contributor

@hamnis hamnis left a comment

LGTM

@rossabaker rossabaker added enhancement Feature requests and improvements retarget Cherry-pick or reopen on another branch labels Sep 22, 2020
@rossabaker
Copy link
Member

rossabaker commented Sep 22, 2020

Nice. Backporting to series/0.21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests and improvements retarget Cherry-pick or reopen on another branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants