Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ScalaDocs for Headers, with RFC links. #3670

Merged
merged 1 commit into from Sep 21, 2020

Conversation

diesalbla
Copy link
Contributor

@diesalbla diesalbla commented Aug 31, 2020

No description provided.

Copy link
Member

@rossabaker rossabaker left a comment

This is great. I think we should cherry-pick back to 0.21.

@rossabaker rossabaker added docs Relates to our website or tutorials retarget Cherry-pick or reopen on another branch labels Sep 2, 2020
Daenyth
Daenyth approved these changes Sep 2, 2020
Copy link
Contributor

@Daenyth Daenyth left a comment

@rossabaker Is there a reason to not merge this yet?

@diesalbla
Copy link
Contributor Author

diesalbla commented Sep 2, 2020

@Daenyth Sorry... Scalafmt problems...

@diesalbla
Copy link
Contributor Author

diesalbla commented Sep 5, 2020

@rossabaker The build failed because of some tests failed:

[info] Passed: Total 18, Failed 0, Errors 0, Passed 18, Pending 2
[error] Failed: Total 1641, Failed 1, Errors 0, Passed 1639, Skipped 1, Pending 2
[error] Failed tests:
[error] 	org.http4s.QueryParamCodecSpec

@Daenyth
Copy link
Contributor

Daenyth commented Sep 8, 2020

@rossabaker Is that a known flappy test?

@hamnis
Copy link
Contributor

hamnis commented Sep 21, 2020

@Daenyth yes. this is fixed by #3691 which we should merge asap

@hamnis hamnis merged commit 1f6917c into http4s:master Sep 21, 2020
@rossabaker
Copy link
Member

rossabaker commented Sep 22, 2020

Also backported to series/0.21. I left out the conflicts due to newly modeled headers on master. This gets most of it.

@diesalbla diesalbla deleted the document_some_headers branch Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Relates to our website or tutorials retarget Cherry-pick or reopen on another branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants