Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for 'OptionalValidatingQueryParamDecoderMatcher'. #3710

Merged
merged 7 commits into from Sep 25, 2020

Conversation

kevinmeredith
Copy link
Contributor

@kevinmeredith kevinmeredith commented Sep 24, 2020

Document this powerful matcher.

Copy link
Member

@ChristopherDavenport ChristopherDavenport left a comment

This is after the link table and should be placed before the link table.

@kevinmeredith
Copy link
Contributor Author

kevinmeredith commented Sep 24, 2020

Hi @ChristopherDavenport - thanks for reviewing. You're talking about how my changes are after https://github.com/http4s/http4s/pull/3710/files#diff-f5604df42f3b16985fefa40783ef823cR519?

Please say more since I'm not sure how to address your comment.

@kevinmeredith
Copy link
Contributor Author

kevinmeredith commented Sep 25, 2020

Perhaps 746ec8b addresses your comment, @ChristopherDavenport?

@hamnis hamnis merged commit 8055ceb into http4s:series/0.21 Sep 25, 2020
@kevinmeredith kevinmeredith deleted the include-param-decoder branch Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants