Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gzip in webjar service #3735

Merged
merged 3 commits into from Oct 14, 2020
Merged

Gzip in webjar service #3735

merged 3 commits into from Oct 14, 2020

Conversation

ashwinbhaskar
Copy link
Collaborator

@ashwinbhaskar ashwinbhaskar commented Oct 10, 2020

No description provided.

Copy link
Member

@rossabaker rossabaker left a comment

Nice!

*/
class WebjarServiceBuilder[F[_]] private (
blocker: Blocker,
webjarAssetFilter: WebjarServiceBuilder.WebjarAssetFilter,
cacheStrategy: CacheStrategy[F],
classLoader: Option[ClassLoader]) {
classLoader: Option[ClassLoader],
preferGzipped: Boolean) {
Copy link
Member

@rossabaker rossabaker Oct 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we added a secondary constructor here, this could be binary compatible and added to 0.21. What do you think?

Copy link
Collaborator Author

@ashwinbhaskar ashwinbhaskar Oct 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rossabaker series/21 branch does not have WebjarServiceBuilder. It just has a WebjarService object - https://github.com/http4s/http4s/blob/series/0.21/server/src/main/scala/org/http4s/server/staticcontent/WebjarService.scala

Copy link
Member

@rossabaker rossabaker Oct 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, bad memory/assumption on my part.

@rossabaker rossabaker added the enhancement Feature requests and improvements label Oct 11, 2020
@rossabaker rossabaker added this to the 1.0.0-M5 milestone Oct 13, 2020
@rossabaker rossabaker merged commit c4255f7 into http4s:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests and improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants