Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolving PrometheusExportService path comparison failure #3738

Merged
merged 2 commits into from Oct 12, 2020
Merged

resolving PrometheusExportService path comparison failure #3738

merged 2 commits into from Oct 12, 2020

Conversation

jyoo980
Copy link
Contributor

@jyoo980 jyoo980 commented Oct 11, 2020

Should be work that resolves #3731

@rossabaker rossabaker added bug Determined to be a bug in http4s retarget Cherry-pick or reopen on another branch labels Oct 12, 2020
@rossabaker
Copy link
Member

rossabaker commented Oct 12, 2020

Thanks! When this is ready, we'll cherrypick it back to series/0.21.

@jyoo980
Copy link
Contributor Author

jyoo980 commented Oct 12, 2020

Looks like this was the only place where we were doing a raw string comparison for the path; other usages had the correct comparison to a Path

@jyoo980 jyoo980 changed the title adding .toString on path to resolve equality check issues resolving PrometheusExportService path comparison failure Oct 12, 2020
Copy link
Member

@rossabaker rossabaker left a comment

Thanks!

hamnis
hamnis approved these changes Oct 12, 2020
Copy link
Contributor

@hamnis hamnis left a comment

Apparently I missed a spot.
The universal equality things are sometimes hard to find.

Good find. thanks for the fix

@hamnis
Copy link
Contributor

hamnis commented Oct 12, 2020

Thanks! When this is ready, we'll cherrypick it back to series/0.21.

Why? this is only a problem for 1.0 and master

@rossabaker rossabaker removed the retarget Cherry-pick or reopen on another branch label Oct 12, 2020
@rossabaker
Copy link
Member

rossabaker commented Oct 12, 2020

You're right. I was looking for binary compatibility without thinking.

@rossabaker rossabaker merged commit 10d738e into http4s:master Oct 12, 2020
@jyoo980 jyoo980 deleted the jy/rework-pathInfo-equality-checks branch Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Determined to be a bug in http4s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus metrics route never matches in 1.0.0-M4
3 participants