Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ListSep parser according to RFC2616 #3743

Merged
merged 2 commits into from Oct 15, 2020

Conversation

satorg
Copy link
Contributor

@satorg satorg commented Oct 14, 2020

Resolves #3657.

@satorg
Copy link
Contributor Author

satorg commented Oct 14, 2020

Checks fail with these errors:

Error:  laws: Failed binary compatibility check against org.http4s:http4s-laws_2.13:0.21.4! Found 4 potential problems
Error:   * abstract synthetic method org$http4s$laws$discipline$ArbitraryInstances$_setter_$genOptWs_=(org.scalacheck.Gen)Unit in interface org.http4s.laws.discipline.ArbitraryInstances is present only in current version
Error:     filter with: ProblemFilters.exclude[ReversedMissingMethodProblem]("org.http4s.laws.discipline.ArbitraryInstances.org$http4s$laws$discipline$ArbitraryInstances$_setter_$genOptWs_=")
Error:   * abstract synthetic method org$http4s$laws$discipline$ArbitraryInstances$_setter_$genListSep_=(org.scalacheck.Gen)Unit in interface org.http4s.laws.discipline.ArbitraryInstances is present only in current version
Error:     filter with: ProblemFilters.exclude[ReversedMissingMethodProblem]("org.http4s.laws.discipline.ArbitraryInstances.org$http4s$laws$discipline$ArbitraryInstances$_setter_$genListSep_=")
Error:   * abstract method genOptWs()org.scalacheck.Gen in interface org.http4s.laws.discipline.ArbitraryInstances is present only in current version
Error:     filter with: ProblemFilters.exclude[ReversedMissingMethodProblem]("org.http4s.laws.discipline.ArbitraryInstances.genOptWs")
Error:   * abstract method genListSep()org.scalacheck.Gen in interface org.http4s.laws.discipline.ArbitraryInstances is present only in current version
Error:     filter with: ProblemFilters.exclude[ReversedMissingMethodProblem]("org.http4s.laws.discipline.ArbitraryInstances.genListSep")

This is because I added some additional generators to ArbitraryInstances.
Honestly, I'm unsure how to tackle it better.
Should I extract the new generators into a separate trait or something?

@rossabaker @hamnis could you suggest please?

@rossabaker
Copy link
Member

rossabaker commented Oct 15, 2020

We could perhaps add them to the companion object, but not the trait, for 0.21. In hindsight, I don't think the arbitraries mix-in is a successful design.

Copy link
Member

@rossabaker rossabaker left a comment

👍 on green

@rossabaker rossabaker added this to the 0.21.8 milestone Oct 15, 2020
@rossabaker rossabaker merged commit 3553f72 into http4s:series/0.21 Oct 15, 2020
@satorg satorg deleted the fix-listsep-parser branch Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants