Ember flaky test fix #3752
Merged
Ember flaky test fix #3752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Double slash in absence of scheme - Dot-segment when there is no scheme and authority, but path segment contains a colon
rossabaker
approved these changes
Oct 25, 2020
|
|
||
| case Uri(None, None, _, _, _) => | ||
| } | ||
|
|
||
| this match { | ||
| case Uri(_, Some(_), p, _, _) if p.nonEmpty && !p.startsWith("/") => | ||
| writer << "/" << p | ||
| case Uri(None, None, p, _, _) => | ||
| if (p.contains(":")) | ||
| writer << "./" << p // https://tools.ietf.org/html/rfc3986#section-4.2 last paragraph |
There was a problem hiding this comment.
I've probably read that RFC a dozen times and never noticed this rule. Great find.
ChristopherDavenport
approved these changes
Oct 26, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.