Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember flaky test fix #3752

Merged
merged 3 commits into from Oct 27, 2020
Merged

Ember flaky test fix #3752

merged 3 commits into from Oct 27, 2020

Conversation

ashwinbhaskar
Copy link
Collaborator

@ashwinbhaskar ashwinbhaskar commented Oct 19, 2020

No description provided.

@ashwinbhaskar ashwinbhaskar changed the title [WIP] Ember flaky test fix Ember flaky test fix Oct 24, 2020
@ashwinbhaskar ashwinbhaskar requested a review from rossabaker Oct 24, 2020
- Double slash in absence of scheme
- Dot-segment when there is no scheme and authority, but path segment contains a colon
@rossabaker rossabaker added the bug Determined to be a bug in http4s label Oct 25, 2020
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work! Thanks for finding the root cause.


case Uri(None, None, _, _, _) =>
}

this match {
case Uri(_, Some(_), p, _, _) if p.nonEmpty && !p.startsWith("/") =>
writer << "/" << p
case Uri(None, None, p, _, _) =>
if (p.contains(":"))
writer << "./" << p // https://tools.ietf.org/html/rfc3986#section-4.2 last paragraph
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've probably read that RFC a dozen times and never noticed this rule. Great find.

Copy link
Member

@ChristopherDavenport ChristopherDavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this one really bugged me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Determined to be a bug in http4s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants