sbt-1.4.1 and friends #3757
Merged
sbt-1.4.1 and friends #3757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 20, 2020
Closed
|
The stricter MiMa rules are haunting us. |
rossabaker
commented
Oct 21, 2020
| // Restore binary compatibility with mixin forwarder | ||
| // TODO remove in 1.0 | ||
| override implicit def http4sMethodSyntax(method: Method): Http4sDsl.MethodOps = | ||
| new Http4sDsl.MethodOps(method) | ||
|
|
||
| // Restore binary compatibility with mixin forwarder | ||
| // TODO remove in 1.0 | ||
| override implicit def http4sMethodConcatSyntax(methods: MethodConcat): Http4sDsl.MethodConcatOps = | ||
| new Http4sDsl.MethodConcatOps(methods) |
There was a problem hiding this comment.
I'm not fully understanding why this works, but it appeased MiMa?
rossabaker
commented
Oct 21, 2020
| @@ -85,6 +85,7 @@ lazy val core = libraryProject("core") | |||
| scalaReflect(scalaVersion.value) % Provided, | |||
| vault, | |||
| ), | |||
| unusedCompileDependenciesFilter -= moduleFilter("org.scala-lang", "scala-reflect"), | |||
There was a problem hiding this comment.
This was only an issue on Scala 2.12. It very certainly is used! I don't know what's going on here.
aeons
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Pulls in a compatible sbt-explicit-dependencies that's blocking #3755.