[WIP] adding first pass at parenthesizing lambdas with regexp #3798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossabaker
approved these changes
Nov 8, 2020
|
We'll want this on series/0.21, because Dotty needs it, and Dotty support forked off that branch. |
rossabaker
pushed a commit
that referenced
this pull request
Nov 11, 2020
|
Cherry-picked this, and scalafmtAll isn't eating them anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Used regexp:
\{ .*:.*=>since I had issues getting thesimulacrum-scalafixplugin working.See #3768 for more details.
I'm not super confident that a regexp fix is great, since it's so fragile. That said I'll keep looking at making the scalafix rule work.