Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] adding first pass at parenthesizing lambdas with regexp #3798

Closed
wants to merge 1 commit into from
Closed

[WIP] adding first pass at parenthesizing lambdas with regexp #3798

wants to merge 1 commit into from

Conversation

jyoo980
Copy link
Contributor

@jyoo980 jyoo980 commented Nov 3, 2020

Used regexp: \{ .*:.*=> since I had issues getting the simulacrum-scalafix plugin working.

See #3768 for more details.

I'm not super confident that a regexp fix is great, since it's so fragile. That said I'll keep looking at making the scalafix rule work.

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incremental progress. I'm surprised we didn't have to remove the line from the scalafmt config, however.

@rossabaker rossabaker added the retarget Cherry-pick or reopen on another branch label Nov 11, 2020
@rossabaker rossabaker added this to In progress in Dotty cross-compilation via automation Nov 11, 2020
@rossabaker
Copy link
Member

We'll want this on series/0.21, because Dotty needs it, and Dotty support forked off that branch.

@rossabaker
Copy link
Member

Cherry-picked this, and scalafmtAll isn't eating them anymore.

@rossabaker rossabaker closed this Nov 11, 2020
Dotty cross-compilation automation moved this from In progress to Done Nov 11, 2020
@jyoo980 jyoo980 deleted the jy/parenthesized-lambdas branch Nov 12, 2020
@jyoo980 jyoo980 restored the jy/parenthesized-lambdas branch Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
retarget Cherry-pick or reopen on another branch
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants