Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt-http4s-org to 0.4.0 #3825

Closed

Conversation

scala-steward
Copy link
Contributor

Updates org.http4s:sbt-http4s-org from 0.3.1 to 0.4.0.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.http4s", artifactId = "sbt-http4s-org" } ]

labels: sbt-plugin-update, semver-minor

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to require attention with its sbt-github-actions integration.

@rossabaker
Copy link
Member

This one is somewhat urgent. Our builds are using deprecated GitHub Actions calls and will start failing on Monday.

@amesgen
Copy link
Member

amesgen commented Nov 12, 2020

I am working on this.

@rossabaker
Copy link
Member

rossabaker commented Nov 12, 2020

Great! The workflow steps suggested by the plugin seem like reasonable defaults within the org, but feel free to override.

I think the org plugin is checking sbt formatting, which is something we've never done in this repo. We could and probably eventually should, but there are so many live branches, we might want to hold on that step for the time being.

@amesgen
Copy link
Member

amesgen commented Nov 12, 2020

I think the org plugin is checking sbt formatting, which is something we've never done in this repo. We could and probably eventually should, but there are so many live branches, we might want to hold on that step for the time being.

Yeah, I copy-pasted and modified the steps for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants