Add Ability to pass own client in AsyncHttpClient so that it's state can be referenced #3859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossabaker
reviewed
Nov 14, 2020
| def getTotalConnectionCount: F[Long] = F.delay(underlying.getTotalConnectionCount) | ||
| def getTotalActiveConnectionCount: F[Long] = F.delay(underlying.getTotalActiveConnectionCount) | ||
| def getTotalIdleConnectionCount: F[Long] = F.delay(underlying.getTotalIdleConnectionCount) | ||
| def getStatsPerHost: F[mutable.Map[String, HostStats]] = |
There was a problem hiding this comment.
Could we return an immutable map here?
| override def remove(pred: java.util.function.Predicate[Cookie]): Boolean = false | ||
| override def clear(): Boolean = false | ||
| } | ||
|
|
||
| final case class AsyncHttpClientStats[F[_]: Sync](private val underlying: ClientStats)(implicit |
There was a problem hiding this comment.
I don't think I'd make this a case class. There is no meaningful equals, toString, etc, and it's not exactly a product type.
There was a problem hiding this comment.
Makes sense, I've made it a simple class
| override def remove(pred: java.util.function.Predicate[Cookie]): Boolean = false | ||
| override def clear(): Boolean = false | ||
| } | ||
|
|
||
| final case class AsyncHttpClientStats[F[_]: Sync](private val underlying: ClientStats)(implicit |
There was a problem hiding this comment.
I'd put this class in its own source file.
There was a problem hiding this comment.
Moved to it's own file
rossabaker
approved these changes
Nov 14, 2020
|
Thanks for reviewing it @rossabaker! I can't merge it though since I don't have write access to the repository |
|
We usually aim for two reviewers, but sometimes our reviewers get busy. I'll go ahead and merge it, and aim to release it this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Currently there is no way to access
org.asynchttpclient.DefaultAsyncHttpClient#getClientStatwhen we create aResource[F, Client[F]]usingorg.http4s.client.asynchttpclient.AsyncHttpClient#resource.This PR adds an additional apply method in
AsyncHttpClientwhich lets the user pass in their ownDefaultAsyncHttpClientso that they can have a handle on its state and use it for metrics etc.