Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use sbt-github-actions #3868

Merged
merged 1 commit into from Nov 15, 2020

Conversation

amesgen
Copy link
Member

@amesgen amesgen commented Nov 15, 2020

Supersedes and closes #3825

See #3847 for more discussion.

@amesgen
Copy link
Member Author

amesgen commented Nov 15, 2020

CI does not trigger again, I (still) have no idea why. The CI output for this commit is here: https://github.com/amesgen/http4s/actions/runs/363811493

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work!

- status-success=Build and Test (ubuntu-latest, 2.13.3, adopt@1.15)
- status-success=Build and Test (ubuntu-latest, 2.12.12, adopt@1.8)
- status-success=Build and Test (ubuntu-latest, 2.12.12, adopt@1.11)
- status-success=Build and Test (ubuntu-latest, 2.12.12, adopt@1.15)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't historically blocked mergify on 1.15, which we're testing just to get out ahead of any problems. But I don't mind adding it as a gate.

Copy link
Member Author

@amesgen amesgen Nov 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, didn't know that. If any annoying problems occur on Java 15, we can disable these checks again. 👍

@rossabaker
Copy link
Member

I'm curious whether subsequent PRs get tested after we merge this.

@rossabaker rossabaker merged commit b457858 into http4s:series/0.21 Nov 15, 2020
@rossabaker
Copy link
Member

I expect we'll have a couple annoying issues coming out of this, but it's definitely the way forward, and the status quo falls apart tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants