Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated actions in release.yml #3870

Merged
merged 3 commits into from Nov 15, 2020

Conversation

rossabaker
Copy link
Member

Still have some deprecated calls to add-path, which will begin failing tomorrow.

@rossabaker rossabaker added the CI Relates to the health of our builds label Nov 15, 2020
@rossabaker rossabaker requested a review from amesgen Nov 15, 2020
@rossabaker
Copy link
Member Author

This file could maybe be managed by GitHub Actions, too?

@amesgen's PR seems to be working well on the other workflow. This one just didn't get tickled until it was merged to a release branch.

Copy link
Member

@amesgen amesgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Releasing is already managed by sbt-github-actions, I just forgot to delete release.yml.

I would suggest to simply delete release.yml in this PR, unless I am overlooking sth.

@amesgen
Copy link
Member

amesgen commented Nov 15, 2020

One thing that we might want to adapt is the set of branches where we want to publish snapshots: config

@rossabaker
Copy link
Member Author

Ah, that's where it is! I thought you'd set that up, but my search came up empty.

And 👍 to tweaking the snapshots targets.

@rossabaker
Copy link
Member Author

One thing that we might want to adapt is the set of branches where we want to publish snapshots

We used to have an environment variable so it would trigger publishSigned instead of ci-release: CI_SNAPSHOT_RELEASE: +publishSigned. I think that might be necessary, too? We'll find out soon, because I merged to main.

@amesgen
Copy link
Member

amesgen commented Nov 15, 2020

Ah yes, one can do this by adding this env var here.

@rossabaker
Copy link
Member Author

It might not have mattered? Looks like it succesfully published a snapshot on main without that environment: https://github.com/http4s/http4s/runs/1403222551?check_suite_focus=true

@amesgen
Copy link
Member

amesgen commented Nov 15, 2020

This env var seems to enable signing, see the documentation for CI_SNAPSHOT_RELEASE here: https://github.com/olafurpg/sbt-ci-release/blob/master/readme.md . I don't know how important that is for http4s. It was enabled in #3159.

@amesgen
Copy link
Member

amesgen commented Nov 15, 2020

BTW: The CI workflow you linked (https://github.com/http4s/http4s/runs/1403222551?check_suite_focus=true) is from release.yml, which has not yet been deleted in main. The publishing job from ci.yml (which is managed by sbt-github-actions) is here: https://github.com/http4s/http4s/runs/1403257157

@rossabaker
Copy link
Member Author

Oh, yeah. Signing snapshots isn't that critical (I don't even know if anybody uses them), but it's a nice thing to do if we publish them.

And you're right about the branches. So many moving parts. I think this is now good, and can merge to main?

@amesgen
Copy link
Member

amesgen commented Nov 15, 2020

Yes, this should be ready. We could additional branches for snapshot publishing in this PR here (as discussed above), but this can wait.

@rossabaker rossabaker merged commit 0c4d77b into series/0.21 Nov 15, 2020
@rossabaker rossabaker deleted the update-release-gh-actions branch Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Relates to the health of our builds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants