New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deprecated actions in release.yml #3870
Conversation
This file could maybe be managed by GitHub Actions, too? @amesgen's PR seems to be working well on the other workflow. This one just didn't get tickled until it was merged to a release branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Releasing is already managed by sbt-github-actions, I just forgot to delete release.yml.
I would suggest to simply delete release.yml in this PR, unless I am overlooking sth.
One thing that we might want to adapt is the set of branches where we want to publish snapshots: config |
Ah, that's where it is! I thought you'd set that up, but my search came up empty. And |
We used to have an environment variable so it would trigger |
Ah yes, one can do this by adding this env var here. |
It might not have mattered? Looks like it succesfully published a snapshot on |
This env var seems to enable signing, see the documentation for |
BTW: The CI workflow you linked (https://github.com/http4s/http4s/runs/1403222551?check_suite_focus=true) is from release.yml, which has not yet been deleted in main. The publishing job from ci.yml (which is managed by sbt-github-actions) is here: https://github.com/http4s/http4s/runs/1403257157 |
Oh, yeah. Signing snapshots isn't that critical (I don't even know if anybody uses them), but it's a nice thing to do if we publish them. And you're right about the branches. So many moving parts. I think this is now good, and can merge to main? |
Yes, this should be ready. We could additional branches for snapshot publishing in this PR here (as discussed above), but this can wait. |
Still have some deprecated calls to add-path, which will begin failing tomorrow.