Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MethodOps apply returns Request[F] #3903

Merged
merged 1 commit into from Nov 24, 2020
Merged

MethodOps apply returns Request[F] #3903

merged 1 commit into from Nov 24, 2020

Conversation

Lasering
Copy link
Contributor

Fix #2738

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That didn't ripple nearly as hard as I feared! Nice cleanup.

@Lasering
Copy link
Contributor Author

Now I would like to tackle #2483, which will probably ripple.

@rossabaker rossabaker merged commit ed32a5d into http4s:main Nov 24, 2020
@Lasering Lasering deleted the fix-client-generator branch November 24, 2020 17:43
@rossabaker
Copy link
Member

Docs builds on main started hanging when this was merged. Don't yet know why, or if this is the cause, but it has been consistent since.

rossabaker added a commit that referenced this pull request Nov 25, 2020
rossabaker added a commit that referenced this pull request Nov 25, 2020
Fix docs for client DSL changes in #3903
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client EmptyRequestGenerator and EntityRequestGenerator return types
2 participants