Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rendering of URIs with colons #3921

Merged
merged 2 commits into from Nov 25, 2020
Merged

Fix rendering of URIs with colons #3921

merged 2 commits into from Nov 25, 2020

Conversation

RafalSumislawski
Copy link
Member

Fix for #3920

@rossabaker rossabaker added this to the 0.21.12 milestone Nov 24, 2020
@rossabaker rossabaker added the bug Determined to be a bug in http4s label Nov 24, 2020
@rossabaker
Copy link
Member

Good find. I need to go eat, but we'll hold 0.21.12 for this and I'll review it tonight. Also pinged Ashwin since he was recently immersed in this spec.

rossabaker
rossabaker approved these changes Nov 25, 2020
View changes
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done.

@rossabaker rossabaker merged commit ae06f76 into http4s:series/0.21 Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossabaker rossabaker rossabaker approved these changes

@ashwinbhaskar ashwinbhaskar ashwinbhaskar approved these changes

Assignees
No one assigned
Labels
bug Determined to be a bug in http4s
Projects
None yet
Milestone
0.21.12
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RafalSumislawski @rossabaker @ashwinbhaskar