Add Order And Hash Instance For Charset #3937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossabaker
reviewed
Nov 26, 2020
There was a problem hiding this comment.
We can cherry-pick this to series/0.21. (If you're not making breaking changes, always target series/0.21.) Could throw in a Hash instance for extra credit, but it'll need to be in the same value as the Order to avoid competing Eqs. See #3902 for an example of that.
|
@rossabaker oh sorry about that. I had meant to target series/0.21, but I guess I wasn't paying attention yesterday. I'll get that fixed and add the |
|
Needs a scalafmt, but otherwise looks good. |
isomarcte
force-pushed
the
charset-order-instances
branch
from
3ff2316
to
d18fe44
Compare
|
@rossabaker updated. |
isomarcte
force-pushed
the
charset-order-instances
branch
from
d18fe44
to
353bd0d
Compare
isomarcte
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.