Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Order Instance For Method #3966

Merged
merged 3 commits into from Dec 2, 2020

Conversation

isomarcte
Copy link
Member

This commit also updates the law tests for Hash[Method] as they were not actually testing the HashLaws, just the EqLaws.

@isomarcte isomarcte changed the base branch from main to series/0.21 November 28, 2020 19:46
This commit also updates the law tests for `Hash[Method]` as they were not actually testing the HashLaws, just the EqLaws.
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@isomarcte
Copy link
Member Author

@rossabaker I noticed this had a duplicate import after the implicits <-> syntax merge. I've updated to fix that.

@rossabaker
Copy link
Member

Ugh, 0-for-2 in my browser merges. Now I remember why I don't do that.

@rossabaker rossabaker merged commit a81b4a6 into http4s:series/0.21 Dec 2, 2020
@isomarcte isomarcte deleted the method-order-instance branch December 2, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants