Port more tests to munit #3983
Merged
Port more tests to munit #3983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Quiroz <carlos.m.quiroz@gmail.com>
cquiroz
commented
Dec 5, 2020
| body: String | ||
| ) | ||
|
|
||
| // test("FollowRedirect should ggfollow the proper strategy") { |
There was a problem hiding this comment.
This test was marked as pending and it is a bit hard to port as it uses the Tables feature of spec. Instead I just commented it out. Perhaps it should be removed
There was a problem hiding this comment.
Drop it for now. #3986 so it can be revived later, if we can.
cquiroz
commented
Dec 5, 2020
| EntityEncoder.simple[IO, ErrorJson](`Content-Type`(MediaType.application.json))(json => | ||
| Chunk.bytes(json.value.getBytes())) | ||
|
|
||
| // TODO: These won't work without an Eq for (Message[IO], Boolean) => DecodeResult[IO, A] |
There was a problem hiding this comment.
This was commented in the original
cquiroz
commented
Dec 5, 2020
| assert(EntityDecoder.text[IO].matchesMediaType(MediaType.text.css)) | ||
| } | ||
|
|
||
| /* TODO: Parameterization |
There was a problem hiding this comment.
It was commented in the original
rossabaker
approved these changes
Dec 6, 2020
|
Do you want to take care of the merges again? I already did dotty, because it was trivial. |
Merged
|
Sure I'm do main and cats effect 3 which I guess will still not compile |
This was referenced Dec 6, 2020
rossabaker
added a commit
to http4s/http4s-servlet
that referenced
this pull request
Apr 3, 2022
Port more tests to munit
armanbilge
pushed a commit
to http4s/http4s-play-json
that referenced
this pull request
May 2, 2022
Port more tests to munit
armanbilge
pushed a commit
to http4s/http4s-prometheus-metrics
that referenced
this pull request
May 2, 2022
Port more tests to munit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is another batch of tests ported to munit focused on tests using
Http4sLegacyMatchers. I hope with another batch I can remove the legacy matcher classes.