/ http4s Public
Accept-Ranges parser with cats-parse implementation
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
This is a preliminary PR to request feedback, it does not fully replace
I added the cats-parse implementation to the
Accept-Rangescompanion object and I'd like some general feedback on my usage of cats-parse and any formatting/style stuff.
I also have a question about the previous implementation, (here) the top level rule for
Accept-Rangesis matching on EOL but this caused the cats-parse version to fail tests, I assume that parboiled2 is different from cats-effect and this is not necessary but I want to confirm this.