Replace Accept-Ranges parser with cats-parse implementation
#3995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossabaker
requested changes
Dec 9, 2020
|
|
||
| /* https://tools.ietf.org/html/rfc7233#appendix-C */ | ||
| val parser: P[`Accept-Ranges`] = { | ||
| val ListSep: P[Unit] = Rfc7230.ows *> P.char(',') *> Rfc7230.ows |
There was a problem hiding this comment.
This will do a fine job on the ows-comma-ows that reasonable actors will send, but not the empty elements between commas (including leading and trailing commas) that the spec mandates. Rfc7230.headerRep1 should take care of those.
| val parser: P[`Accept-Ranges`] = { | ||
| val ListSep: P[Unit] = Rfc7230.ows *> P.char(',') *> Rfc7230.ows | ||
|
|
||
| val none = P.string1("none").as(Nil) |
| ) | ||
| ) | ||
|
|
||
| acceptableRanges.map(headers.`Accept-Ranges`.apply) /* is EOL necessary? */ |
There was a problem hiding this comment.
I think this is correct. Calling parseAll means Accept-Ranges.parse will have to consume the entire input, and if this is composed into other parsers, we want it to leave the leftovers.
|
Last commit should implement requested changes. |
rossabaker
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is a preliminary PR to request feedback, it does not fully replace
RangeParseryet.I added the cats-parse implementation to the
Accept-Rangescompanion object and I'd like some general feedback on my usage of cats-parse and any formatting/style stuff.I also have a question about the previous implementation, (here) the top level rule for
Accept-Rangesis matching on EOL but this caused the cats-parse version to fail tests, I assume that parboiled2 is different from cats-effect and this is not necessary but I want to confirm this.