Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rfc7235 with cats-parse #4001

Merged
merged 18 commits into from Dec 18, 2020
Merged

Rfc7235 with cats-parse #4001

merged 18 commits into from Dec 18, 2020

Conversation

hamnis
Copy link
Contributor

@hamnis hamnis commented Dec 9, 2020 •
edited

Implemented all

  • Authorization
  • WWW-Authenticate
  • Proxy-Authenicate
  • Proxy-Authorization

@hamnis
Copy link
Contributor Author

hamnis commented Dec 10, 2020

Seems like it has to do with backtracking, and here my parsing skills fail.

@hamnis hamnis changed the title WiP authorization header Authorization header with cats-parse Dec 10, 2020
@rossabaker rossabaker added this to In progress in Dotty cross-compilation via automation Dec 10, 2020
@hamnis hamnis mentioned this pull request Dec 11, 2020
Closed
34 tasks
@hamnis hamnis changed the title Authorization header with cats-parse Rfc7235 with cats-parse Dec 11, 2020
rossabaker
rossabaker requested changes Dec 12, 2020
View reviewed changes
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Just a couple concerns. This will also need MiMa exceptions for the removed parsers.

core/src/main/scala/org/http4s/headers/Authorization.scala Outdated Show resolved Hide resolved
core/src/main/scala/org/http4s/internal/parsing/Rfc7235.scala Outdated Show resolved Hide resolved
core/src/main/scala/org/http4s/internal/parsing/Rfc7235.scala Outdated Show resolved Hide resolved
tests/src/test/scala/org/http4s/parser/AuthorizationHeaderSpec.scala Show resolved Hide resolved
@hamnis hamnis force-pushed the authorization-header-cats-parse branch from da5089c to 246a340 Compare December 14, 2020 08:12
@hamnis hamnis force-pushed the authorization-header-cats-parse branch from 3a32375 to 801bd21 Compare December 18, 2020 11:18
rossabaker
rossabaker approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@hamnis hamnis merged commit f01f2d7 into dotty Dec 18, 2020
Dotty cross-compilation automation moved this from In progress to Done Dec 18, 2020
@hamnis hamnis deleted the authorization-header-cats-parse branch December 18, 2020 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regadas regadas regadas left review comments

@rossabaker rossabaker rossabaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Dotty cross-compilation
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hamnis @rossabaker @regadas