Add Resource Based Middlewares To BracketRequestResponse.
#4026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isomarcte
force-pushed
the
bracket-resource
branch
from
0def83c
to
df9ac43
Compare
|
Is |
The compiler can't figure out the implicits in 2.12.
rossabaker
approved these changes
Dec 17, 2020
| val P: Profunctor[Kleisli[OptionT[F, *], *, *]] = Profunctor[Kleisli[OptionT[F, *], *, *]] | ||
| (contextRoutes: ContextRoutes[A, F]) => | ||
| val contextRoutes0: ContextRoutes[(A, F[Unit]), F] = | ||
| P.lmap(contextRoutes)(_.map(_._1)) |
There was a problem hiding this comment.
If using Profunctor here is so painful, how about doing contextRoutes.local(_.map(_._1)) instead?
There was a problem hiding this comment.
@nigredo-tori sure. Updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
As requested by (and effectively written by) @nigredo-tori (#3977 (comment))