Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter nowarn annotation from jar #4070

merged 1 commit into from Jan 3, 2021


Copy link

Alternative to #4067. We just simply filter the @nowarn annotation out of the jar.


  • No new core dependencies
  • Preserves fatal warnings without further complexity


  • Compat trait will need to be copied to a scala-3 directory on the Dotty branch.
  • Doesn't steer our source toward modernity.
  • MiMa doesn't catch that the annotations are missing. But we'll note it and move on, and it's 2.12 only.

Copy link
Member Author

I'm leaning toward this being the better approach, and conservatively putting it on main instead of 0.21.

@rossabaker rossabaker changed the base branch from series/0.21 to main January 3, 2021 04:51
@rossabaker rossabaker merged commit 659c58b into http4s:main Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant