blaze-server on CE3 #4097
blaze-server on CE3 #4097
Conversation
|
ah, we'll need to fix blaze-core up again since fs2 deprecates |
| .dequeueChunk1(batchSize) | ||
| .map(_.toList) | ||
| def pollBatch(batchSize: Int, timeoutSeconds: Long): IO[List[WebSocketFrame]] = { | ||
| def batch(acc: List[WebSocketFrame]): IO[List[WebSocketFrame]] = |
There was a problem hiding this comment.
we should probably add a batched take operation to the CE queue, but it's getting mighty close to fs2 realm
There was a problem hiding this comment.
If Queue moved to CE3, then wouldn't the operation?
There was a problem hiding this comment.
CE3 implements a brand new Queue separate from fs2.concurrent.Queue. CE3 doesn't have a concept of chunking (this was deemed an fs2 concern), but I think it probably makes sense to add something anyways
Originally the plan was for fs2 Queue to stick around but it seems like Mike made things work out with the CE3 one
| .dequeueChunk1(batchSize) | ||
| .map(_.toList) | ||
| def pollBatch(batchSize: Int, timeoutSeconds: Long): IO[List[WebSocketFrame]] = { | ||
| def batch(acc: List[WebSocketFrame]): IO[List[WebSocketFrame]] = |
There was a problem hiding this comment.
If Queue moved to CE3, then wouldn't the operation?
blaze-server/src/main/scala/org/http4s/server/blaze/BlazeBuilder.scala
Outdated
Show resolved
Hide resolved
blaze-server/src/main/scala/org/http4s/server/blaze/BlazeServerBuilder.scala
Outdated
Show resolved
Hide resolved
blaze-server/src/main/scala/org/http4s/server/blaze/BlazeServerBuilder.scala
Outdated
Show resolved
Hide resolved
blaze-server/src/main/scala/org/http4s/server/blaze/Http1ServerStage.scala
Outdated
Show resolved
Hide resolved
blaze-server/src/main/scala/org/http4s/server/blaze/Http1ServerStage.scala
Outdated
Show resolved
Hide resolved
blaze-server/src/main/scala/org/http4s/server/blaze/Http1ServerStage.scala
Show resolved
Hide resolved
blaze-server/src/main/scala/org/http4s/server/blaze/Http1ServerStage.scala
Outdated
Show resolved
Hide resolved
blaze-server/src/main/scala/org/http4s/server/blaze/Http1ServerStage.scala
Outdated
Show resolved
Hide resolved
|
@rossabaker Seems like |
|
Yes, |
|
I think everything looks good here now |
This was fairly straightforward, we just need to think more about where we want to expose the
Dispatcherarguments