Port ok http client #4102
Port ok http client #4102
Conversation
| @@ -89,12 +84,11 @@ sealed abstract class OkHttpBuilder[F[_]] private ( | |||
| private def run(req: Request[F]) = | |||
| Resource.suspend(F.async[Resource[F, Response[F]]] { cb => | |||
| okHttpClient.newCall(toOkHttpRequest(req)).enqueue(handler(cb)) | |||
| () | |||
| F.delay(Option(F.unit)) | |||
There was a problem hiding this comment.
This is really an F[Option[F[Unit]]?
It looks pure instead of delayed, at least.
There was a problem hiding this comment.
The easiest way to migrate old uncancelable async code, is to use async_ , which has the same signature of the old async. The old code didn't shift back after async, whereas with ce3 it will, fyi.
| extends BackendBuilder[F, Client[F]] { | ||
| private[this] val logger = getLogger | ||
|
|
||
| private def invokeCallback[F[_]](logger: Logger)(f: => Unit)(implicit | ||
| F: Sync[F]): Unit = | ||
| F.blocking(f).unsafeRunSync |
There was a problem hiding this comment.
Is there a Dispatcher floating around that I don't see? Also does this need to be blocking?
There was a problem hiding this comment.
Added the dispatcher and made a few changes.
| * | ||
| * @define WHYNOSHUTDOWN It is assumed that the OkHttp client is | ||
| * passed to us as a Resource, or that the caller will shut it down, or | ||
| * that the caller is comfortable letting OkHttp's resources expire on | ||
| * their own. | ||
| * | ||
| * @param okHttpClient the underlying OkHttp client. | ||
| * @param blockingExecutionContext $BLOCKINGEC | ||
| * @param dispatcher $BLOCKINGEC |
There was a problem hiding this comment.
I think the reference needs to be changed to $DISPATCHER here.
| extends BackendBuilder[F, Client[F]] { | ||
| private[this] val logger = getLogger | ||
|
|
||
| type Result[F[_]] = Either[Throwable, Resource[F, Response[F]]] |
There was a problem hiding this comment.
Can this alias be private to reduce API liability?
No description provided.