/ http4s Public
CirceEntityEncoder: avoid intermediate ByteBuffer duplication #4124
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
EntityEncoderfor Json, there is a call to the
fs2.Chunk.ByteBuffercompanion object, which
duplicates the given byte buffer. By default, the printer from
circegenerates a new ByteBuffer for each Json, so we do not need to duplicate it. WE avoid it by calling the
This should save memory allocations proportional to the size of the response.