CirceEntityEncoder: avoid intermediate ByteBuffer duplication #4124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EntityEncoder for Circe Json library calls the `apply` method of the `Chunk.ByteBuffer` class, which _duplicates_ the given ByteBuffer. Since the `circe` printer generates a distinct ByteBuffer for each Json, we do not need that duplication and so call to the `view` method instead.
diesalbla
force-pushed
the
circeentityencoder_save_array
branch
from
64153b9
to
0fcac7d
Compare
Daenyth
approved these changes
Jan 2, 2021
|
Good find. I'm going to cherry-pick this back to 0.21. |
rossabaker
pushed a commit
that referenced
this pull request
Jan 2, 2021
The EntityEncoder for Circe Json library calls the `apply` method of the `Chunk.ByteBuffer` class, which _duplicates_ the given ByteBuffer. Since the `circe` printer generates a distinct ByteBuffer for each Json, we do not need that duplication and so call to the `view` method instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In the
EntityEncoderfor Json, there is a call to theapplymethod offs2.Chunk.ByteBuffercompanion object, whichduplicates the given byte buffer. By default, the printer from
circegenerates a new ByteBuffer for each Json, so we do not need to duplicate it. WE avoid it by calling theviewmethod instead.This should save memory allocations proportional to the size of the response.