Cats parse uri #4132
Cats parse uri #4132
Conversation
| * "conservative in our sending behavior and liberal in our | ||
| * receiving behavior", and encode them. | ||
| */ | ||
| private[http4s] def parser: Parser[Query] = { |
There was a problem hiding this comment.
This was a val in the original PR, there were some initialization ordering issues that caused a NPE
There was a problem hiding this comment.
This is one of the dangerous of putting the parsers on the companions. We don't get compiler help with the ordering of eager vals. I'm not sure how heavy creating a new Parser instance every time is. We possibly want a lazy val here, or to understand the cycle that caused this. But this gets us moving forward.
| val bracketedIpv6 = char('[') *> Rfc3986.ipv6 <* char(']') | ||
| val host = List(bracketedIpv6, Rfc3986.ipv4, stringHost).reduceLeft(_ orElse1 _) | ||
| val bracketedIpv6 = char('[') *> Uri.Ipv6Address.parser <* char(']') | ||
| val host = List(bracketedIpv6, Uri.Ipv4Address.parser, stringHost).reduceLeft(_ orElse1 _) |
There was a problem hiding this comment.
I think we should unnest these types from the Uri, but that can wait until we merge this to main.
| """Invalid input ' ', expected Pchar, '/', '?', '#' or 'EOI' (line 1, column 21): | ||
| http://example.org/a file | ||
| ^""".replace("\r", "") | ||
| "Error(20,NonEmptyList(EndOfString(20,25)))" |
There was a problem hiding this comment.
Future note: this is something we'll want to improve in ParseResult.parseFrom. There's a LocationMap that will help with the arrow. And bosatsu allegedly has a nicer formatter already.
|
Interesting: a few of these builds got canceled for hanging. |
|
The build hang is a pre-existing condition, and in trying to stabilize that, I hit the warning on the Link parser that this fixes. I think we should merge this to dotty now, and I'll beat on the hanging before we merge dotty to main. |
| } | ||
|
|
||
| "only parse part of an invalid ipv6 address where a single section is shortened (must be 2 or more)" in { | ||
| val invalidIp = "2001:db8::1:1:1:1:1" | ||
| Rfc3986.ipv6.parse(invalidIp).map(_._2.value) must beRight("2001:db8::1:1:1:1") | ||
| Ipv6Address.fromString(invalidIp).map(_.value) must beLeft |
There was a problem hiding this comment.
Clarified with @lewisjkl on #4004: they were Rights because the tests are using parse, and don't consume all input. They flipped from left to right when the Parser.ends were removed.
Ipv6Address.fromString uses parseAll, which is a "clientside end", which correctly flips these back to lefts. Jeff was right, and now so is this.
Opening up another PR (original at #4095) so I can run builds here