Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally omit empty content length in blaze-client #4152



Copy link

Alternative approach to #4109. It seems kind of awkward that we have to do this but it is what it is. Though I think it's worth entertaining because it doesn't make a semantically breaking change: people may be submitting bodies on GET requests today, even though that may be frowned upon

Also, apologies for submitting this on the cats-effect-3 branch

@RaasAhsan RaasAhsan changed the title Conditionally omit empty content length Conditionally omit empty content length in blaze-client Jan 7, 2021
Copy link

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this approach and willing to backport it. It's not so cats-effecty, so I might even just cherry-pick this one and let it merge its way through.

@rossabaker rossabaker closed this Jan 8, 2021
@rossabaker rossabaker deleted the branch http4s:cats-effect-3 January 8, 2021 18:48
Copy link

Incorrectly autoclosed when cats-effect-3 branch was merged. But I was going to cherry-pick it anyway. I'll do that next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants