Conditionally omit empty content length in blaze-client #4152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaasAhsan
changed the title
added 3 commits
January 7, 2021 00:07
rossabaker
approved these changes
Jan 7, 2021
|
Incorrectly autoclosed when cats-effect-3 branch was merged. But I was going to cherry-pick it anyway. I'll do that next. |
rossabaker
pushed a commit
that referenced
this pull request
Jan 8, 2021
rossabaker
added a commit
that referenced
this pull request
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Alternative approach to #4109. It seems kind of awkward that we have to do this but it is what it is. Though I think it's worth entertaining because it doesn't make a semantically breaking change: people may be submitting bodies on GET requests today, even though that may be frowned upon
Also, apologies for submitting this on the cats-effect-3 branch