port tomcat to CE3 #4216
Merged
port tomcat to CE3 #4216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossabaker
reviewed
Jan 18, 2021
| classloader: Option[ClassLoader] | ||
| )(implicit protected val F: ConcurrentEffect[F]) | ||
| classloader: Option[ClassLoader], | ||
| private val dispatcher: Dispatcher[F] |
There was a problem hiding this comment.
Customizing the dispatcher is uninteresting, so several of the backends have started provisioning their own in resource. The JettyBuilder has an example of this, and how it gets wired through the servlet mounts.
You kind of hinted at that already with the create method, but creating a Resource of the builder rather than a resource of the server isn't something we've done elsewhere (that I remember). What do you think of that other pattern?
There was a problem hiding this comment.
That's indeed a much better approach.
Adopted in 8ca50b7 ;)
rossabaker
approved these changes
Jan 18, 2021
rossabaker
added a commit
to http4s/http4s-servlet
that referenced
this pull request
Apr 3, 2022
port tomcat to CE3
rossabaker
added a commit
to http4s/http4s-servlet
that referenced
this pull request
Apr 4, 2022
port tomcat to CE3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fix #4092