Skip to content

Alternative fix for ipv6 #4243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 23, 2021
Merged

Conversation

m-sp
Copy link
Member

@m-sp m-sp commented Jan 23, 2021

No description provided.

@m-sp m-sp mentioned this pull request Jan 23, 2021
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this one easier to understand.

@rossabaker
Copy link
Member

UriParserSpec is now failing. I haven't investigated why yet.

@hamnis
Copy link
Contributor

hamnis commented Jan 23, 2021

@m-sp
Copy link
Member Author

m-sp commented Jan 23, 2021

it was the generator after all. it generates an address which shortens only a single section... exactly what is forbidden in the Rfc3986ParserSpec

@rossabaker
Copy link
Member

Nice find! I'll bet that last commit is something we could fix in series/0.21, for whatever it's worth. (We haven't done much to publicize our arbitraries for outside use.)

@rossabaker
Copy link
Member

I'll look into cherry-picking that commit next time I'm back on series/0.21.

@rossabaker rossabaker merged commit 0d925d6 into http4s:series/0.22 Jan 23, 2021
@m-sp m-sp deleted the alternative-fix-for-ipv6 branch January 23, 2021 23:10
rossabaker pushed a commit that referenced this pull request Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants