Ember stream forking #4244
Merged
Ember stream forking #4244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaasAhsan
commented
Jan 23, 2021
ember-server/src/main/scala/org/http4s/ember/server/internal/ServerHelpers.scala
Outdated
Show resolved
Hide resolved
RaasAhsan
commented
Jan 23, 2021
ember-server/src/main/scala/org/http4s/ember/server/internal/ServerHelpers.scala
Outdated
Show resolved
Hide resolved
RaasAhsan
commented
Jan 23, 2021
ember-server/src/main/scala/org/http4s/ember/server/internal/ServerHelpers.scala
Outdated
Show resolved
Hide resolved
|
@rossabaker if you encounter any issues merging downstream, definitely ping me to help, but I don't anticipate there being any trouble |
ChristopherDavenport
approved these changes
Jan 27, 2021
it's extremely dangerous in the general case :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Follow up to #4179. I introduced a
prefetchcall which is a hack to get the outer stream to terminate and finalize before inner streams do, by buffering streams to a new stream.parJoinalso shuffles the results of the inner stream back out to the new stream which isn't strictly necessary.This PR introduces a
forkingcombinator which behaves identically toparJoinexcept the outer stream can terminate and finalize before the inner stream, and there is no queueing involved.TODO: