Ember startup backpressure #4281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaasAhsan
commented
Jan 27, 2021
| Stream | ||
| .resource( | ||
| sg.serverResource[F](bindAddress, additionalSocketOptions = additionalSocketOptions)) | ||
| .attempt |
There was a problem hiding this comment.
I added a combinator called onComplete to Cats, which is basically attempt + evalTap + rethrow but I don't think it's come downstream yet. If it has, FS2 also has an onComplete so it's probably getting shadowed
ChristopherDavenport
approved these changes
Jan 28, 2021
|
Oh, looks like build is unhappy. This makes a lot of sense to me. |
added 3 commits
January 27, 2021 18:19
RaasAhsan
commented
Jan 28, 2021
| .get(s"http://${server.address.getHostName}:${server.address.getPort}")(_.status.pure[IO]) | ||
| .timeout(5.seconds) | ||
| .assertEquals(Status.Ok) | ||
| } | ||
|
|
||
| // server.test("server startup fails if address is already in use") { case _ => |
There was a problem hiding this comment.
I'm leaving this commented because sometimes the new server can't bind to the same port, even though the server from the previous test has already finalized. Opening a follow up issue
rossabaker
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4280