-
Notifications
You must be signed in to change notification settings - Fork 801
Give User Access To Response to Parsing/Timeout Failures #4287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give User Access To Response to Parsing/Timeout Failures #4287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this just for binary compatibility? Is there any reason not to have a Throwable => F[Response[F]]
? Is the layering to protect against errorHandler
itself failing? I think if that fails, we can give a hardcoded 500.
|
||
@deprecated( | ||
"0.21.17", | ||
"Use errorOfLastResort for end of the line, or error handler for expected effectful handling") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
errorOfLastResort
is gone now, right? I think we just want to point people to errorHandler
entirely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. That's gone. Will fix.
No description provided.