Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify okhttp builder #4299

Merged
merged 3 commits into from
Jan 29, 2021
Merged

Simplify okhttp builder #4299

merged 3 commits into from
Jan 29, 2021

Conversation

ashwinbhaskar
Copy link
Collaborator

No description provided.

@ashwinbhaskar
Copy link
Collaborator Author

@rossabaker can we make the create method private? Because we are exposing Client as a Resource using the resource method.

@rossabaker
Copy link
Member

Yes, I think that's reasonable. create exists because okhttp manages its own lifecycle, and there were no resources. Now that there is a resource that the builder manages, having a raw .create method is less compelling.

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rossabaker rossabaker merged commit 07e8073 into http4s:main Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants