Header cleanups #4352
Merged
Header cleanups #4352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SystemFw
approved these changes
Feb 6, 2021
|
Well, well, look who only compiled core before opening a PR. |
Actually we do use that, and the one that changes in Scala 3 does not take a |
rossabaker
force-pushed
the
header-cleanup
branch
from
0007d4c
to
dec364f
Compare
ashwinbhaskar
approved these changes
Feb 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Some quick wins while we get the header working on Dotty:
GetTis vestigial.get(`Set-Cookie`)has been deprecated since 0.16!* The signature of defaultunapplymethods changes in Scala 3, and we're not using the one onHeaderKeyanyway.