Content-Disposition Content-Location warns clean up #4546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vder
changed the title
|
Hi, could anyone take a look here as I'm not sure what should I do about it. As far as I understand one of the test failed, since it raised exception instead of getting actual value: |
rossabaker
approved these changes
Mar 1, 2021
rossabaker
reviewed
Mar 1, 2021
| override def renderValue(writer: Writer): writer.type = { | ||
| final case class `Content-Disposition`(dispositionType: String, parameters: Map[String, String]) { | ||
| def key: `Content-Disposition`.type = `Content-Disposition` | ||
| lazy val value = v2.Header[`Content-Disposition`].value(this) |
There was a problem hiding this comment.
It's a little weird to depend on our type class instance here. I think it would be best to flip that dependency. I'm also not convinced it still needs to be lazy. But this is forward progress as is, so, 👍.
There was a problem hiding this comment.
Agree, It just I've seen this value field in several other header classes and propagated it here. But I suppose we should rather removing these than adding ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially address #4535