-
Notifications
You must be signed in to change notification settings - Fork 807
Migrate content length header & co #4547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rossabaker
merged 17 commits into
http4s:series/0.22
from
phongngtuan:migrate_content_length_header
Mar 2, 2021
Merged
Migrate content length header & co #4547
rossabaker
merged 17 commits into
http4s:series/0.22
from
phongngtuan:migrate_content_length_header
Mar 2, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e883a6f to
785c6d7
Compare
24 tasks
785c6d7 to
95b57c9
Compare
95b57c9 to
4023d5d
Compare
rossabaker
reviewed
Mar 2, 2021
| writer.addSet(values) | ||
| } | ||
|
|
||
| implicit def headerSelectRenderer[A](implicit select: v2.Header.Select[A]): Renderer[A] = |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the only case where an http4s model type appears in this file. If it works putting this on Select instead of Renderer, I think that would be preferrable. I also just want to get this all compiling again, so I'm content to revisit this later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up the session led by @rossabaker, partially address #4535
Select[A]toRenderer[A]Only the first commit is more or less interesting where the machinery are introduced. Really appreciate if you could take a look before I stray too far from the path. In particular
SimpleHeadersSpecused to take key + value but now only works on value.HeadersSpectodo: