Remove our ipv4 and ipv6 literals#4602
Merged
rossabaker merged 1 commit intoseries/0.22from Mar 9, 2021
Merged
Conversation
hamnis
approved these changes
Mar 9, 2021
kevin-lee
pushed a commit
to kevin-lee/http4s-jetty
that referenced
this pull request
May 9, 2025
Remove our ipv4 and ipv6 literals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our
ipv4andipv6clash with ip4s'.I think this change actually make the ergnomics of the Uri model worse, but so does this conflict. all the more reason to invest in a good URI interpolator?