added isErrorOrStatus function and tests for RetryPolicy #4636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -162,8 +162,11 @@ object RetryPolicy { | |||
| isErrorOrRetriableStatus(result) | |||
|
|
|||
| def isErrorOrRetriableStatus[F[_]](result: Either[Throwable, Response[F]]): Boolean = | |||
| isErrorOrStatus(result, RetriableStatuses) | |||
|
|
|||
| def isErrorOrStatus[F[_]](result: Either[Throwable, Response[F]], status: Set[Status]): Boolean = | |||
There was a problem hiding this comment.
If we could get a comment on this vs the other use case. As these were the only option previously. A little documentation on how and why you might use it would be useful as it was only clear to me after I looked at the unit test, which isn't in the same place as the source.
There was a problem hiding this comment.
@ChristopherDavenport I have added a description. Let me know if it makes sense or if there is a better wording for it
ChristopherDavenport
approved these changes
Mar 23, 2021
|
I think this can be cherry-picked back to 0.21 and released faster. I'll try that. |
rossabaker
pushed a commit
that referenced
this pull request
Mar 24, 2021
|
This will be in the next 0.21 release (as well as 0.22 and 1.0). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title, adding the new function to allow more control over the response checker