Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember: Idle vs Header Receive Timeouts #4637

Merged
merged 1 commit into from Mar 24, 2021

Conversation

ChristopherDavenport
Copy link
Member

  1. On reused connections which have empty buffers we should delay for the full idle period, and not timeout on the shorter header timeout. This addresses that.
  2. On the very first connection we should automatically start reading headers.
  3. We should be clear what is the cause of our timeouts, perhaps in even more places. This doesn't change the class but changes the message to more clearly indicate the cause of the timeout.

@rossabaker rossabaker merged commit 37a218f into http4s:series/0.21 Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants