Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove private from no-cache set #4646

Merged
merged 1 commit into from Mar 28, 2021
Merged

Remove private from no-cache set #4646

merged 1 commit into from Mar 28, 2021

Conversation

arixmkii
Copy link
Contributor

Fixes #4645

rossabaker
rossabaker approved these changes Mar 28, 2021
View reviewed changes
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're correct here. There's a tradition of using many directives to cover all versions of all common user agents, but private is a contradiction, and I can't find anything that recommends it for what we're trying to accomplish here.

@rossabaker rossabaker merged commit 58002ee into http4s:series/0.21 Mar 28, 2021
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossabaker rossabaker rossabaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arixmkii @rossabaker