FileService: Querying /file.png/anything where /file.png is a file throws #4654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScalaWilliam
changed the title
ScalaWilliam
force-pushed
the
file-under-file-exception
branch
from
727e873
to
01d8439
Compare
rossabaker
requested changes
Mar 28, 2021
| @@ -86,13 +85,14 @@ object FileService { | |||
| case _ => OptionT.none | |||
| } | |||
| resolvedPath | |||
| .semiflatMap(path => F.delay(path.toRealPath(LinkOption.NOFOLLOW_LINKS))) | |||
| .flatMapF(path => | |||
| F.delay(if (Files.exists(path)) Some(path.toRealPath(LinkOption.NOFOLLOW_LINKS)) | |||
There was a problem hiding this comment.
Can we add the same LinkOption to the exists call to make it consistent with the toRealPath?
There was a problem hiding this comment.
Done - thank you for pointing it out.
Exception is `java.nio.file.FileSystemException: Not a directory`. Found bot queries in Scala Algorithms logs that are leading to an HTTP 5xx error. To avoid this, we explicitly check if what we are querying is a file, before attempting to resolve the real path; the exception is currently raised in particular where `.toRealPath` is called. Alternative approach would be to capture the `FileSystemException` as well, but it could hide other errors like `AccessDeniedException`. Because we already do a check, the check for `NoSuchFileException` becomes redundant.
ScalaWilliam
force-pushed
the
file-under-file-exception
branch
from
01d8439
to
8e46331
Compare
|
I still think this is potentially an issue in the two related services, but this is good on its own. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Exception is
java.nio.file.FileSystemException: Not a directory.Found bot queries in Scala Algorithms logs that are leading to an HTTP 5xx error.
To avoid this, we explicitly check if what we are querying is a file, before attempting to resolve the real path; the exception is currently raised in particular where
.toRealPathis called.Alternative approach would be to capture the
FileSystemExceptionas well, but it could hide other errors likeAccessDeniedException. Because we already do a check, the check forNoSuchFileExceptionbecomes redundant.Before changing main code:
