Add custom dns resolver to BlazeClientBuilder. #4699
Conversation
There was a problem hiding this comment.
Thanks! Yes, this is eventually merged to series/0.22 and main, and would be in all three releases. Starting it here lets you use it in a stable release ASAP.
Binary compatibility is broken because the constructor for BlazeClientBuilder changed. We can fix that with a deprecated auxiliary constructor (example, or I guess just add a MiMa exception since it's private. I usually prefer the deprecated constructors, just to be 100% sure.
This might be a compelling feature in Ember, too, but we can handle that in a separate PR.
| @@ -57,7 +58,8 @@ sealed abstract class BlazeClientBuilder[F[_]] private ( | |||
| val executionContext: ExecutionContext, | |||
| val scheduler: Resource[F, TickWheelExecutor], | |||
| val asynchronousChannelGroup: Option[AsynchronousChannelGroup], | |||
| val channelOptions: ChannelOptions | |||
| val channelOptions: ChannelOptions, | |||
| val customDnsResolver: Option[RequestKey => Either[Throwable, InetSocketAddress]] | |||
There was a problem hiding this comment.
Not sure this needs to be an Option: could we just have a default based on the getAddress that's used today?
There was a problem hiding this comment.
Done. Also moved getAddress to BlazeClientBuilder.
| @@ -57,7 +58,8 @@ sealed abstract class BlazeClientBuilder[F[_]] private ( | |||
| val executionContext: ExecutionContext, | |||
| val scheduler: Resource[F, TickWheelExecutor], | |||
| val asynchronousChannelGroup: Option[AsynchronousChannelGroup], | |||
| val channelOptions: ChannelOptions | |||
| val channelOptions: ChannelOptions, | |||
| val customDnsResolver: Option[RequestKey => Either[Throwable, InetSocketAddress]] | |||
There was a problem hiding this comment.
Something for 1.0: we'll probably want to refine this to the ip4s address type once it becomes public API.
Well, maybe not, if blaze is just using java.net internally. It's a bigger issue for things with deeper fs2 integration. Anyway, something to think about.
Hi, AFAIK there is currently no way to add custom DNS resolver for blaze-client (similar to one provided in akka-http (this PR and here in docs).
I kinda need that feature, potential use cases are in linked akkka-http doc.
I added new parameter in
BlazeClientBuilder-customDnsResolver- which is passed toHttp1Supportand if present - used instead of getAddress.I'm glad to adjust/change implementation if it is not suitable.
Also, are changes from
series/0.21eventually merged to 1.0.0 series (main), or should I submit separate PR for it?