Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle errors/close socket in ember server initial req read #4715

Merged
merged 2 commits into from Apr 7, 2021
Merged

handle errors/close socket in ember server initial req read #4715

merged 2 commits into from Apr 7, 2021

Conversation

sbuzzard
Copy link

@sbuzzard sbuzzard commented Apr 5, 2021

This fixes the issue #4714 by adding the same error handling around the initial read as is around the runApp such that errors are converted to Lefts, the stream is ended and the socket closed.

@rossabaker rossabaker added the bug Determined to be a bug in http4s label Apr 5, 2021
@rossabaker rossabaker merged commit 4361733 into http4s:series/0.21 Apr 7, 2021
rossabaker added a commit that referenced this pull request Apr 7, 2021
@rossabaker
Note #4715
bee421f
@RaasAhsan RaasAhsan mentioned this pull request Aug 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isomarcte isomarcte isomarcte approved these changes

@ChristopherDavenport ChristopherDavenport ChristopherDavenport approved these changes

Assignees
No one assigned
Labels
bug Determined to be a bug in http4s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sbuzzard @isomarcte @ChristopherDavenport @rossabaker