Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle errors/close socket in ember server initial req read #4715



Copy link

@sbuzzard sbuzzard commented Apr 5, 2021

This fixes the issue #4714 by adding the same error handling around the initial read as is around the runApp such that errors are converted to Lefts, the stream is ended and the socket closed.

@rossabaker rossabaker added the bug Determined to be a bug in http4s label Apr 5, 2021
@rossabaker rossabaker merged commit 4361733 into http4s:series/0.21 Apr 7, 2021
rossabaker added a commit that referenced this pull request Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
bug Determined to be a bug in http4s
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants