Draining bug fix #4750
Merged
Draining bug fix #4750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 14, 2021 23:45
rossabaker
approved these changes
Apr 15, 2021
|
|
||
| package org.http4s.ember.core | ||
|
|
||
| private[ember] final case class EmptyStreamError() extends Exception("Cannot Parse Empty Stream") |
There was a problem hiding this comment.
Nit: I don't love exceptions being case classes. It implies equality where there is none. I see you're using it as an extractor, but I usually catch these by type.
There was a problem hiding this comment.
This is also not a hill I'll die on, but every other exception type defined in that package is also a case class, and most of them are not used in a match clause :) . If we want to go one way or the other, I'm all for for following well-defined guidelines
There was a problem hiding this comment.
Agree, I care about consistency more than which way we go. Let's merge, and we can revisit the case class bikeshed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4731. The issue here was that we would drain a socket's read buffer before the response was written to the socket. This can manifest in the aforementioned bug because the input stream will only be evaluated when we try to write. But if we drain the connection before we write, we'll end up closing because we see unread bytes.
So the fix is to drain after the response is written to the socket. I've also done some QoL to make things easier to read and follow. There might be some merge conflicts with #4735 which I can deal with
TODO: